My understanding from talking to a liberal law professor and reading a relevant case is that–contrary to much of the chatter–the constitutionality of the NSA spying is actually unclear.

Yes. As I note below, many people think the Constitution provides far more protection for privacy in communications than it actually does under existing caselaw.